The gift that keeps on giving is a catchphrase, first known as a marketing slogan for the phonograph since 1924, trademarked in the United States in 1927. It means that the benefits of this gift keep on increasing with time.
Other uses
References
The gift that keeps on giving Wikipedia(Text) CC BY-SA